Newly disconnected connections are set as broken (#3381)

* Address+Fix #3353
redis · Apr 27, 2023 · 52a10e1 · 52a10e1
1 parent e0f0357
commit 52a10e1
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/main/java/redis/clients/jedis/Connection.java b/src/main/java/redis/clients/jedis/Connection.java
@@ -190,13 +190,21 @@ public void connect() throws JedisConnectionException {
 
         outputStream = new RedisOutputStream(socket.getOutputStream());
         inputStream = new RedisInputStream(socket.getInputStream());
+
+        broken = false; // unset broken status when connection is (re)initialized
+
       } catch (JedisConnectionException jce) {
-        broken = true;
+
+        setBroken();
         throw jce;
+
       } catch (IOException ioe) {
-        broken = true;
+
+        setBroken();
         throw new JedisConnectionException("Failed to create input/output stream", ioe);
+
       } finally {
+
         if (broken) {
           IOUtils.closeQuietly(socket);
         }
@@ -228,10 +236,10 @@ public void disconnect() {
         outputStream.flush();
         socket.close();
       } catch (IOException ex) {
-        broken = true;
         throw new JedisConnectionException(ex);
       } finally {
         IOUtils.closeQuietly(socket);
+        setBroken();
       }
     }
   }