Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster): make blocking commands works with cluster #867

Merged
merged 2 commits into from
May 15, 2019
Merged

fix(cluster): make blocking commands works with cluster #867

merged 2 commits into from
May 15, 2019

Conversation

luin
Copy link
Collaborator

@luin luin commented May 13, 2019

As discussed in #850, we should use a separate connection for refreshing slots to avoid conflict with blocking commands invoked by users.

There are three tests failed in these changes. Still need some investigations.

@luin luin mentioned this pull request May 13, 2019
Closed
manasa-ei
manasa-ei reviewed May 14, 2019
View reviewed changes
Copy link

@manasa-ei manasa-ei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to raise the PR on the latest build I can see there is some code changes with this version to the latest one such as timeout is not moved to utils_1 folder.

@luin
Copy link
Collaborator Author

luin commented May 14, 2019

@manasa-ei It seems this commit was made on top of the latest commit:

ioredis git:fix/cluster-blocking-commands ❯ git show 718a238^                                                                                    ✭
commit b323c1cbf968a076c838a404f68b387ee82648db (tag: v4.9.4, origin/master, origin/HEAD, master)
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Mon May 13 14:58:27 2019 +0000

    chore(release): 4.9.4 [skip ci]

Do I miss anything?

@manasa-ei
Copy link

@luin Seems working fine with this fix. My bad I didn't check properly, yes the push is on latest commit. Please go ahead and merge it.

@luin luin merged commit 68db71b into master May 15, 2019
@luin luin deleted the fix/cluster-blocking-commands branch May 15, 2019 04:34
ioredis-robot pushed a commit that referenced this pull request May 15, 2019
@semantic-release-bot
chore(release): 4.9.5 [skip ci]
9d9c292 
## [4.9.5](v4.9.4...v4.9.5) (2019-05-15)

### Bug Fixes

* **cluster:** make blocking commands works with cluster ([#867](#867)) ([68db71b](68db71b)), closes [#850](#850) [#850](#850)
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.9.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RidgeA
Copy link

RidgeA commented May 15, 2019

Awesome, thanks!

@sikmir sikmir mentioned this pull request Oct 27, 2021
Closed
janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
@janus-dev87
chore(release): 4.9.5 [skip ci]
929cdd3 
## [4.9.5](redis/ioredis@v4.9.4...v4.9.5) (2019-05-15)

### Bug Fixes

* **cluster:** make blocking commands works with cluster ([#867](redis/ioredis#867)) ([68db71b](redis/ioredis@68db71b)), closes [#850](redis/ioredis#850) [#850](redis/ioredis#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasa-ei manasa-ei manasa-ei left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luin @manasa-ei @ioredis-robot @RidgeA