Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non-utf8 command name #866

Merged
merged 2 commits into from
May 13, 2019
Merged

Conversation

luin
Copy link
Collaborator

@luin luin commented May 13, 2019

This commit uses Buffer.byteLength() insteand of String#length to handle non-utf8 command names.

Close #862

luin added 2 commits May 13, 2019 22:40
This commit uses Buffer.byteLength() insteand of
String#length to handle non-utf8 command names.

Close #862
@luin luin merged commit 9ddb58b into master May 13, 2019
@luin luin deleted the fix/handle-invalid-command-name branch May 13, 2019 14:56
ioredis-robot pushed a commit that referenced this pull request May 13, 2019
## [4.9.4](v4.9.3...v4.9.4) (2019-05-13)

### Bug Fixes

* handle non-utf8 command name ([#866](#866)) ([9ddb58b](9ddb58b)), closes [#862](#862)
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
## [4.9.4](redis/ioredis@v4.9.3...v4.9.4) (2019-05-13)

### Bug Fixes

* handle non-utf8 command name ([#866](redis/ioredis#866)) ([9ddb58b](redis/ioredis@9ddb58b)), closes [#862](redis/ioredis#862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uncaughtException TypeError: Cannot read property 'command' of undefined
2 participants