Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retryTime option when redis server not ready #784

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Jan 21, 2019

attempt to fix #783

@luin
Copy link
Collaborator

luin commented Jan 21, 2019

Thank you for the pull request! I would like to have an option like maxLoadingRetryTime instead since allowing users to limit to max waiting time may be more useful in practice.

@luin
Copy link
Collaborator

luin commented Jan 21, 2019

What about giving a default value for this option (like 10s)? So people won't be blocked to long if they don't notice this option.

@luin luin merged commit 0e7713f into redis:master Jan 21, 2019
ioredis-robot pushed a commit that referenced this pull request Jan 21, 2019
# [4.6.0](v4.5.1...v4.6.0) (2019-01-21)

### Features

* add maxLoadingRetryTime option when redis server not ready ([#784](#784)) ([0e7713f](0e7713f))
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
# [4.6.0](redis/ioredis@v4.5.1...v4.6.0) (2019-01-21)

### Features

* add maxLoadingRetryTime option when redis server not ready ([#784](redis/ioredis#784)) ([0e7713f](redis/ioredis@0e7713f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max redis server still loading
3 participants