Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cluster): make disconnecting from cluster faster #721

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

luin
Copy link
Collaborator

@luin luin commented Oct 14, 2018

This commit will prevent status changes from 'disconnecting'
to 'connecting' and will stop connecting to a nodes
when disconnecting, which will make disconnecting faster.

This commit will prevent status changes from 'disconnecting'
to 'connecting' and will stop connecting to a nodes
when disconnecting, which will make disconnecting faster.
@luin luin force-pushed the fix/cluster-better-disconnecting branch from 7d7fe22 to fa124d2 Compare October 14, 2018 18:49
@luin luin requested a review from AVVS October 14, 2018 18:49
return wrapper(new Error('Cluster is disconnected.'))
switch (_this.status) {
case 'close':
case 'end':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same error returned for 3 statuses, was this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"disconnecting" returns a different error.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't notice the difference at the end

@luin luin merged commit ce46d6b into master Oct 15, 2018
@luin luin deleted the fix/cluster-better-disconnecting branch October 15, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants