Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for ready state before resolving cluster.connect() #647

Closed
wants to merge 3 commits into from
Closed

wait for ready state before resolving cluster.connect() #647

wants to merge 3 commits into from

Conversation

shaharmor
Copy link
Collaborator

No description provided.

@shaharmor shaharmor requested a review from luin June 28, 2018 20:48
@luin
Copy link
Collaborator

luin commented Jun 29, 2018

LGTM! We should also make Redis#connect() resolved only when the status is ready to keep the behavior same. I'll post a pull request for this.

@luin luin changed the base branch from master to v4 June 29, 2018 15:50
@luin
Copy link
Collaborator

luin commented Jun 29, 2018

Committed to #642 with cherry-pick. See also for the changes on Redis: #648

@luin luin closed this Jun 29, 2018
@luin luin deleted the cluster-wait-for-ready branch March 14, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luin luin Awaiting requested review from luin

Assignees

@luin luin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaharmor @luin