ISSUE-1024 keyPrefix option support Redis Cluster

[cobolbaby]

#1024

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs, but feel free to re-open a closed issue if needed.

[cobolbaby]

@luin Could the bugfix be merged into the trunk?

[eltonpao]

We're looking for this to be merged as well

[murbanowicz]

What about this bug? We hit this issue today. This is a crazy simple bugfix and it is waiting for a merge for over 5 months already.
@luin

[luin]

Sorry for the late response. It was indeed an oversight but the fix is somehow a breaking change so I think we should ship this fix in the next major release. For now, we may add a usage notice to README.md to save people's time.

Thanks for the contribution @cobolbaby !

[murbanowicz]

To be honest I wouldn't consider it as breaking change but bugfix.
At this moment ioredis basically does not respect keyPrefix provided in redisOptions which is expected way of doing that (reflected in typings) which is clearly a bug.

For this moment I had to add it to top-level options and it works with Cluster but this is hopefully not long term solution...

[guruprasadgvmf]

lookgs good

[guruprasadgvmf]

when is this shipping ?

[guruprasadgvmf]

why exactly is this a breaking change?

[lala7573]

This should be a bugfix.. or please update the documents :'( when is the next major release? any updates?

[luin]

Hey @cobolbaby 👋
Sorry for the late response! Resolved this issue with #1522. Thanks for the contribution!