Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for index and search with missing / empty values #315

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

atakavci
Copy link
Collaborator

Closes/Fixes #314

  • Adding parameters to Schema and Field types API
  • Unit/integrations tests for index creation and query

Copy link

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except that class name change, LGTM!

@redis redis deleted a comment from vladvildanov Jun 26, 2024
@atakavci
Copy link
Collaborator Author

the comment from @vladvildanov regarding to use of FLUSHALL has got deleted mistakenly (i have no idea how i achived that).

comment from @vladvildanov :

I guess because there's no distinguish before integration and unit tests, you have to run it in each integration test?

Maybe as a tech debt it makes sense to create a distinguish between tests, and make sure that FLUSHALL runs before each integration test automatically. I know that usually framework provide some kind of "hook" for it, methods like onSetUp() or smth simillar

response from @atakavci :

i am planning to come up with a set of improvements and cleanups overall the code base.
i will take this what you suggested with FLUSHALL as part of it and work on to improve and clean up all uses.
i didnt yet spend time on if we'll distinguish tests and how to approach in case we will. But this is another topic to work on in my list.

@atakavci atakavci merged commit 9b05acd into redis:master Jun 26, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for indexing and querying missing and empty values
3 participants