Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source.gradle-kotlin-dsl instead of source.kotlin to avoid clashes with other Kotlin grammars #3463

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Jan 15, 2024

The grammar is currently only used for Gradle Kotlin DSL (.gradle.kts) scripts, however uses the same scope as regular Kotlin grammars (source.kotlin). This causes it to silently override the Kotlin syntax highlighting, even in .kt files, when another grammar is installed. See #3377 (comment) for further rationale.

This fixes the issue by using a new scope for the Kotlin grammar, namely source.gradle-kotlin-dsl.

@fbricon fbricon added this to the End January 2024 milestone Jan 15, 2024
@fbricon fbricon merged commit 56f2cfb into redhat-developer:master Jan 15, 2024
2 checks passed
@fbricon
Copy link
Collaborator

fbricon commented Jan 15, 2024

Thanks @fwcd!

@fwcd fwcd deleted the gradle-kotlin-dsl-scope branch January 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants