chore: RHIDP-3048: Add release name to dynamic-plugins configmap name #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic-plugins configmap currently has a hard-coded name of 'dynamic-plugins' which prevents having two Developer Hub installations in the same namespace. This pull request updates the name of the 'dynamic-plugins' configmap to include the name of the release such as '<release>-dynamic-plugins' which will alleviate this issue and allow multiple installations of Developer Hub per namespace using Helm.
gazarenkov
approved these changes
Jul 12, 2024
rm3l
approved these changes
Jul 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic-plugins configmap currently has a hard-coded name of 'dynamic-plugins' which prevents having two Developer Hub installations in the same namespace.
This pull request updates the name of the 'dynamic-plugins' configmap to include the name of the release such as '-dynamic-plugins' which will alleviate this issue and allow multiple installations of Developer Hub per namespace using Helm.
Description of the change
Existing or Associated Issue(s)
https://issues.redhat.com/browse/RHIDP-3048
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.