Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: platform parameter is not supported by buildah config (build-without-containerfile) #83

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix: platform parameter is not supported by buildah config (build-without-containerfile) #83

merged 1 commit into from
Oct 18, 2021

Conversation

jayaddison
Copy link
Contributor

Description

The buildah config command does not currently support the platform parameter.

#75 introduced support for platform in both build-from-containerfile (which uses buildah bud) and build-without-containerfile (which uses buildah config).

This pull request removes support for platform during builds-without-containerfile, and raises an error if the user attempts that.

Related Issue(s)

Resolves #82.

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

  • Remove unsupported platform parameter during build-without-containerfile

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it more clear, can we add this input is not supported for build without containerfile in action.yml platform input?

@jayaddison
Copy link
Contributor Author

To make it more clear, can we add this input is not supported for build without containerfile in action.yml platform input?

We should make this clearer, yep 👍

Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: (only supported with containerfile builds)

@divyansh42
Copy link
Member

Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: (only supported with containerfile builds)

Sounds better 👍

@divyansh42
Copy link
Member

divyansh42 commented Oct 18, 2021

To save yourself from these types of errors probably you can add git-commit hooks that are present here.

@jayaddison
Copy link
Contributor Author

Sorry, slightly spammy with the commits here, and I realized I forgot to add sign-offs on a few of them. When we are ready I can squash down to a single signed commit.

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

…hout-containerfile)

Signed-off-by: James Addison <jay@jp-hosting.net>
@jayaddison
Copy link
Contributor Author

No problem - apologies for my introducing the problem in the first place!

@divyansh42 divyansh42 merged commit bb88487 into redhat-actions:main Oct 18, 2021
@jayaddison jayaddison deleted the issue-82/platform-not-available-in-buildah-config branch October 18, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] buildah config fails with error unknow flag --platform
3 participants