Request: Add an "Add Selected Objects (Recursively)" button

[johnburnett]

For large-scale renames across many assets it can be painful to repeatedly add the contents of several folders for batch renaming. An easy solution might be to have a button that adds the current selection and all children to the rename list. For the project panel selection, this would recurse into subfolders, and for the hierarchy panel selection this would recurse into child gameobjects.

I think this would be a straighforward change by adding a new button to MulliganRenamerWindow, and a helper method along the lines of LoadSelectedObjectsDeep. Performance might be such that always having the button always enabled would be good (so that clicking the root Assets folder doesn't try to recusively run ObjectIsValidForRename on all assets in the project).

[edwardrowe]

This is a great idea. I think a checkbox would make sense along the edges of the window somewhere. Easy enough to persist it.

[johnburnett]

I'm in the middle of implementing this, but had already gone the path of a button. Obviously can change it, but I was thinking as a button because I'd expect this to be a relatively rare thing to do and if you forget to uncheck the checkbox it's a potentially Bad Day as you wait for Unity to add tons of objects inadvertantly?

[edwardrowe]

I'd say go ahead as you've got it. I'll evaluate the UX and adjust it if I think the checkbox improves it. I don't think it'd be slow to add all children for either game objects or assets but yes if it is I could see where a button could be better.

…

On Wed, Nov 30, 2022, 1:49 PM John Burnett ***@***.***> wrote: I'm in the middle of implementing this, but had already gone the path of a button. Obviously can change it, but I was thinking as a button because I'd expect this to be a relatively rare thing to do and if you forget to uncheck the checkbox it's a potentially Bad Day as you wait for Unity to add tons of objects inadvertantly? — Reply to this email directly, view it on GitHub <#296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBIKJFACA5JTKMMUCFOLTWK6OVBANCNFSM6AAAAAASO6M7SQ> . You are receiving this because you commented.Message ID: ***@***.***>

[edwardrowe]

Thanks for the issue suggestion and for whatever work you are able to contribute!

…

On Wed, Nov 30, 2022, 8:00 PM Edward Rowe ***@***.***> wrote: I'd say go ahead as you've got it. I'll evaluate the UX and adjust it if I think the checkbox improves it. I don't think it'd be slow to add all children for either game objects or assets but yes if it is I could see where a button could be better. On Wed, Nov 30, 2022, 1:49 PM John Burnett ***@***.***> wrote: > I'm in the middle of implementing this, but had already gone the path of > a button. Obviously can change it, but I was thinking as a button because > I'd expect this to be a relatively rare thing to do and if you forget to > uncheck the checkbox it's a potentially Bad Day as you wait for Unity to > add tons of objects inadvertantly? > > — > Reply to this email directly, view it on GitHub > <#296 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADBIKJFACA5JTKMMUCFOLTWK6OVBANCNFSM6AAAAAASO6M7SQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> >