Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: modernize get_version and remove types-pkg_resources #139

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

chore: modernize get_version and remove types-pkg_resources #139

wants to merge 1 commit into from

Conversation

dmaljovec
Copy link
Contributor

update from legion on behalf of @dmaljovec

This will help prevent roadie lock issues stemming from usage of a "yanked" package

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

bengioe
bengioe approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@bengioe bengioe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this particular notebook was changed, but it appears to just be formatting 👍
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengioe bengioe bengioe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmaljovec @bengioe