Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Remove RemoveUnusedParameterRector #5888

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Mar 17, 2021

This rule can be very unreliable without knowing full code context and deep project analysis.
We don't have it even actived here, so better remove it to avoid causing fatal removals

@TomasVotruba TomasVotruba force-pushed the remove-unrelaible-rules branch 2 times, most recently from c8f4762 to 2f2d6e4 Compare March 17, 2021 23:54
@TomasVotruba TomasVotruba merged commit c815334 into main Mar 18, 2021
@TomasVotruba TomasVotruba deleted the remove-unrelaible-rules branch March 18, 2021 00:10
@TomasVotruba
Copy link
Member Author

Yet it can be used on private methods :)

@TomasVotruba TomasVotruba restored the remove-unrelaible-rules branch April 19, 2021 12:26
TomasVotruba added a commit that referenced this pull request Apr 19, 2021
@TomasVotruba TomasVotruba deleted the remove-unrelaible-rules branch April 19, 2021 13:23
TomasVotruba added a commit that referenced this pull request May 16, 2024
rectorphp/rector-src@2deccac [PHPStan] Fix missingType.generics notice on phpstan.neon on PHPStan 1.11 (#5888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant