Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert to array Process->setInput() #647

Merged
merged 1 commit into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ function doNotConvertToArrayCallSetWorkingDirectory()
$process->setWorkingDirectory('/some/other/path');
$process->addOutput('Test output');
$process->addErrorOutput('Test output');
$process->setInput('Test input');
}

?>
Expand All @@ -26,6 +27,7 @@ function doNotConvertToArrayCallSetWorkingDirectory()
$process->setWorkingDirectory('/some/other/path');
$process->addOutput('Test output');
$process->addErrorOutput('Test output');
$process->setInput('Test input');
}

?>
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ final class StringToArrayArgumentProcessRector extends AbstractRector
/**
* @var string[]
*/
private const EXCLUDED_PROCESS_METHOD_CALLS = ['setWorkingDirectory', 'addOutput', 'addErrorOutput'];
private const EXCLUDED_PROCESS_METHOD_CALLS = ['setWorkingDirectory', 'addOutput', 'addErrorOutput', 'setInput'];

public function __construct(
private readonly NodeTransformer $nodeTransformer
Expand Down
Loading