[CodeQuality] skip array + non native response return on ResponseRetu…

…rnTypeControllerActionRector (#661)

rules-tests/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector/Fixture/skip_possible_return_array_or_response_non_native.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\ClassMethod\ResponseReturnTypeControllerActionRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SkipPossibleReturnArrayOrResponseNonNative extends AbstractController
+{
+    /**
+     * @Route("/new", name="some_new")
+     *
+     * @Template(template="Foo:Bar:edit.html.twig")
+     *
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse|array{x: xy, form: \Symfony\Component\Form\FormView}
+     */
+    public function newAction()
+    {
+        $form = $this->createForm(Some::class, $type);
+        $form->handleRequest($request);
+
+        if ($form->isSubmitted() && $form->isValid()) {
+            return $this->someRedirect();
+        }
+
+        return [
+            'x' => 'xy',
+            'form' => $form->createView(),
+        ];
+    }
+
+    private function someRedirect()
+    {
+        return $this->redirect($this->generateUrl('some'));
+    }
+}

rules-tests/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector/Fixture/template_response.php.inc

@@ -29,7 +29,7 @@ final class TemplateController extends AbstractController
 {
     #[Route]
     #[Template]
-    public function testDetail(): ?array
+    public function testDetail(): array
     {
         return [];
     }

rules/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector.php

@@ -134,8 +134,12 @@ public function refactor(Node $node): ?Node
                 }
             }
 
-            $node->returnType = new NullableType(new Identifier('array'));
-            return $node;
+            if ($returnType->isArray()->yes()) {
+                $node->returnType = new Identifier('array');
+                return $node;
+            }
+
+            return null;
         }
 
         return $this->refactorResponse($node);