[TypeDeclaration] Add TypedPropertyFromCreateMockAssignRector #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-typed-property-from-create-mock
branch
2 times, most recently
from
058595a
to
c06536c
Compare
ruudk
reviewed
Jul 23, 2024
|
|
||
| class SomeTest extends TestCase | ||
| { | ||
| public \PHPUnit\Framework\MockObject\MockObject $someMock; |
There was a problem hiding this comment.
shouldn't this be the intersection type?
Suggested change
| public \PHPUnit\Framework\MockObject\MockObject $someMock; | |
| public \PHPUnit\Framework\MockObject\MockObject&SomeMockedClass $someMock; |
There was a problem hiding this comment.
That would be incorrect, as MockObject is a generic type.
Also, goal of this rule is to add type as soon as PHP 7.1/7.4 (return/property)
See native return type here: https://github.com/sebastianbergmann/phpunit/blob/7af36fe694222657332a5f932f29dae99964cedc/src/Framework/TestCase.php#L1339
TomasVotruba
force-pushed
the
tv-typed-property-from-create-mock
branch
from
c06536c
to
7b1cadc
Compare
TomasVotruba
force-pushed
the
tv-typed-property-from-create-mock
branch
from
7b1cadc
to
52f2c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.