[TypeDeclaration] Skip possible void and return by docblock on ReturnTypeFromMockObjectRector #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TypeFromMockObjectRector
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
|
👍 |
staabm
reviewed
Jul 22, 2024
| return null; | ||
| } | ||
|
|
||
| $returnType = $this->getType($soleReturn->expr); |
There was a problem hiding this comment.
I wonder whethere there are real use-cases for getType() anymore, or whether this method should be deprecated in favor of getNativeType...?
There was a problem hiding this comment.
getType() is stil usefull for:
- get type from php native function/methods, yes, it got mixed on getNativeType()
- downgrade process
- get object type from method call / static call
- verify transformation that too much for only native check, eg,
/** @var string $var */
trim($var)that cast (string) is not needed on that case.
There was a problem hiding this comment.
Ok, said differently: its only useful in very few edge cases but the name misleads even rector-src core developers to use it wrongly in lots of situations
There was a problem hiding this comment.
Given rare context, this is used on purpose here 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReturnAnalyzerto verify possible voidgetNativeType()to ensure it returns native type