Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Skip fluent no return type on RemoveUnusedPrivateMethodRector take 2 #6116

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 4, 2024

Ref #6108 (comment)

  • skip called on last
  • allow remove if never called on fluent

@samsonasik samsonasik changed the title [DeadCode] Skip fluent no return type on RemoveUnusedPrivateMethodRector [DeadCode] Skip fluent no return type on RemoveUnusedPrivateMethodRector take 2 Jul 4, 2024
@samsonasik samsonasik marked this pull request as draft July 4, 2024 12:49
@samsonasik samsonasik marked this pull request as ready for review July 4, 2024 13:03
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 3fe5553 into main Jul 4, 2024
33 checks passed
@samsonasik samsonasik deleted the skip-fluent-2 branch July 4, 2024 13:05
@OA
Copy link

OA commented Jul 4, 2024

Hey @samsonasik thanks for fixing this! Any ETA when this will be released? 😄

@samsonasik
Copy link
Member Author

You can use "rector/rector": "dev-main" for now ;)

@TomasVotruba
Copy link
Member

TomasVotruba commented Jul 4, 2024

@OA We usually do release once 2-3 weeks, once few more fixes pile up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants