Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Disable parallel on --debug #5904

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 20, 2024

Currently, debug shows parallel runs and adds extra layer to Recto run. This run is most likely broken already, so we should make it easy to spot the bug as easy as possible.

PHPStan uses same approach and it makes finding bugs much easier - https://phpstan.org/user-guide/command-line-usage#--debug 👍

Let's do the same here 🙂

@samsonasik
Copy link
Member

--debug vs --xdebug is different, /cc @staabm could you verify?

@TomasVotruba
Copy link
Member Author

This is only for --debug option

@TomasVotruba TomasVotruba merged commit d1eb62e into main May 20, 2024
42 checks passed
@TomasVotruba TomasVotruba deleted the tv-debug-disable-parallel branch May 20, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants