-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeadCode] Skip property fetch on cond as may be overridden on RemoveAlwaysTrueIfConditionRector #5796
Conversation
…eAlwaysTrueIfConditionRector
Fixed 🎉 /cc @georgec-floyt |
} | ||
|
||
return false; | ||
return $propertyFetches !== []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip property fetch on if condition seems safer 👍
@gruberroland this also fix rectorphp/rector#8413 as ArrayDimFetch type is unreliable to be removed, related with phpstan bug phpstan/phpstan#10640 |
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Thank you @samsonasik! |
Fixes rectorphp/rector#8583
Fixes rectorphp/rector#8413