Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed #5779

Merged
merged 14 commits into from
Mar 28, 2024
Merged

[Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed #5779

merged 14 commits into from
Mar 28, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 28, 2024 •
edited
Loading

Can be enabled via Rector config:

return RectorConfig::configure()
     // ...
    ->withFluentCallNewLine()
    // ..
;

to ensure no BC break on rector extensions.

@samsonasik samsonasik marked this pull request as draft March 28, 2024 08:07
@samsonasik samsonasik changed the title [Printer] Apply multiline on Fluent Method Call on print [Printer] Apply configurable multiline on Fluent Method Call on print Mar 28, 2024
@samsonasik samsonasik changed the title [Printer] Apply configurable multiline on Fluent Method Call on print [Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed Mar 28, 2024
@samsonasik samsonasik marked this pull request as ready for review March 28, 2024 14:53
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

TomasVotruba
TomasVotruba approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 💪

@TomasVotruba TomasVotruba merged commit 08d73a1 into main Mar 28, 2024
41 checks passed
@TomasVotruba TomasVotruba deleted the dx-muliline-fluent-call branch March 28, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @actions-user