Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Fixes for ArrayDimFetchToMethodCallRector #5727

Merged
merged 1 commit into from
Mar 16, 2024
Merged

[Transform] Fixes for ArrayDimFetchToMethodCallRector #5727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rules/Transform/Rector/ArrayDimFetch/ArrayDimFetchToMethodCallRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ public function refactor(Node $node): ?MethodCall
return null;
}

foreach ($this->arrayDimFetchToMethodCalls as $arrayDimFetchToMethodCall) {
if (! $node->dim instanceof Node) {
return null;
}
if (! $node->dim instanceof Node) {
return null;
}

foreach ($this->arrayDimFetchToMethodCalls as $arrayDimFetchToMethodCall) {
if (! $this->isObjectType($node->var, new ObjectType($arrayDimFetchToMethodCall->getClass()))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterfox this can be improved, by move new ObjectType() in the configuration itself, so just call instead of re-create object, eg:

-new ArrayDimFetchToMethodCall('SomeClass', 'make')
+new ArrayDimFetchToMethodCall(new ObjectType('SomeClass'), 'make')

so only define ObjectType() once in the config ;), like what ArgumentAdderRector do:

rector-src/rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php

Lines 86 to 93 in d9b64c7

new ArgumentAdder(
'SomeExampleClass',
'someMethod',
0,
'someArgument',
true,
new ObjectType('SomeType')
),

return null;
continue;
}

return new MethodCall($node->var, $arrayDimFetchToMethodCall->getMethod(), [new Arg($node->dim)]);
Expand Down