[PHPStanStaticTypeMapper] Do not crash on numeric string on ReturnTypeDeclarationRector

[samsonasik]

It previously got the following error:

There was 1 error:

1) Rector\Tests\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector\Php81RectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Rector\Core\Exception\NotImplementedYetException: Rector\PHPStanStaticTypeMapper\PHPStanStaticTypeMapper::mapToPhpParserNode for PHPStan\Type\Accessory\AccessoryNumericStringType

This PR Fixes rectorphp/rector#6896

[samsonasik]

/cc @internalsystemerror

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Could you add test fixture withotu ): string return type and the other half that adds it? So we're sure this type is completed.

<?php

namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector\FixtureForPhp81;

class DoNotCrashOnNumericString
{
    public function run()
    {
        return bcadd('10', '5');
    }
} 

?>
-----
<?php

namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector\FixtureForPhp81;

class DoNotCrashOnNumericString
{
    public function run(): string
    {
        return bcadd('10', '5');
    }
} 

?>

[samsonasik]

New PHPStan 1.3 just released https://github.com/phpstan/phpstan/releases/tag/1.3.0 and as we use ^1.2 in composer.json, it will automatically updated and #1589 and make error as new PR #1589

I will pin to PHPStan 1.2 and add new fixture for it.

[TomasVotruba]

I will pin to PHPStan 1.2 and add new fixture for it.

Thanks 👍

[samsonasik]

@TomasVotruba I applied:

• temporary pin phpstan to 1.2 as 1.3 cause error like in PR Update to PHPStan ^1.3 #1589 as currently we use ^1.2

• add new fixture for no return declaration, it seems currently cause different result diff:

-    public function run(): string
+    public function run()

[samsonasik]

oh, it seems because bcadd() function not exists, so no return type is expected.

[samsonasik]

Fixed with add the missing function and add string handling 50a27aa so it can add return type declaration.

[TomasVotruba]

Thank you 👍

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[staabm]

Phpstan also supports numeric-string.. not sure this would be correct to use here though

See https://phpstan.org/developing-extensions/type-system

[TomasVotruba]

The PHP doc is also for PHPStorm, that understands only string type.

[TomasVotruba]

Rebase on main is needed now

[TomasVotruba]

Thank you 👍

[internalsystemerror]

@samsonasik @TomasVotruba thank you both!