Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DowngradePhp74][DowngradePhp80] Apply ternary with method_exists on DowngradeReflectionGetTypeRector + DowngradeReflectionGetAttributesRector #1530

Merged
merged 6 commits into from
Dec 20, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 20, 2021

/cc @ondrejmirtes

Reason: ref rectorphp/rector#6878 (comment)

Fixes rectorphp/rector#6878

Applied changes to:

Rector\DowngradePhp74\Rector\MethodCall\DowngradeReflectionGetTypeRector
Rector\DowngradePhp80\Rector\MethodCall\DowngradeReflectionGetAttributesRector

@samsonasik samsonasik force-pushed the apply-method-exists-reflection-get-type-attributes branch from 0f30c5d to 8b71f8c Compare December 20, 2021 08:52
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Neat 😎 👍

@TomasVotruba TomasVotruba merged commit daa4425 into main Dec 20, 2021
@TomasVotruba TomasVotruba deleted the apply-method-exists-reflection-get-type-attributes branch December 20, 2021 11:58
@ondrejmirtes
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade became buggy between 0.12.5 and 0.12.8
4 participants