[Core] Handle printFormatPreserving on inline html with open and close php tag

.github/workflows/e2e.yaml

@@ -24,6 +24,7 @@ jobs:
                 php_version: ['8.0']
                 directory:
                     - 'e2e/template-extends'
+                    - 'e2e/plain-views'
 
         name: End to end test - ${{ matrix.directory }}
 
@@ -44,5 +45,5 @@ jobs:
                 working-directory: ${{ matrix.directory }}
 
             -
-                run: ./../../bin/rector process src --dry-run --ansi -a vendor/autoload.php
+                run: ./../../bin/rector process --dry-run --ansi -a vendor/autoload.php
                 working-directory: ${{ matrix.directory }}

e2e/plain-views/.editorconfig

@@ -0,0 +1,3 @@
+[src/view.php]
+insert_final_newline = false
+trim_trailing_whitespace = false

e2e/plain-views/.gitignore

@@ -0,0 +1 @@
+/vendor

e2e/plain-views/composer.json

@@ -0,0 +1,7 @@
+{
+    "require": {
+        "php": "^8.0"
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true
+}

e2e/plain-views/rector.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use Rector\Core\Configuration\Option;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $parameters = $containerConfigurator->parameters();
+
+    $parameters->set(Option::PATHS, [
+        __DIR__.'/src/',
+    ]);
+};
+

e2e/plain-views/src/view.php

@@ -0,0 +1,4 @@
+
+	<div>
+	<?php echo 1 ?>
+	</div>

e2e/template-extends/rector.php

@@ -3,7 +3,13 @@
 declare(strict_types=1);
 
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use Rector\Core\Configuration\Option;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
+    $parameters = $containerConfigurator->parameters();
+
+    $parameters->set(Option::PATHS, [
+        __DIR__.'/src/',
+    ]);
 };
 

src/PhpParser/Printer/BetterStandardPrinter.php

@@ -26,14 +26,29 @@
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace;
 use Rector\Core\PhpParser\Printer\Whitespace\IndentCharacterDetector;
+use Rector\Core\Provider\CurrentFileProvider;
 use Rector\Core\Util\StringUtils;
+use Rector\Core\ValueObject\Application\File;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Symplify\SmartFileSystem\SmartFileSystem;
 
 /**
  * @see \Rector\Core\Tests\PhpParser\Printer\BetterStandardPrinterTest
  */
 final class BetterStandardPrinter extends Standard
 {
+    /**
+     * @var string
+     * @see https://regex101.com/r/QA7mai/1
+     */
+    private const EMPTY_STARTING_TAG_REGEX = '/^<\\?php\\s+\\?>\\n?/';
+
+    /**
+     * @var string
+     * @see https://regex101.com/r/IVNkrt/1
+     */
+    private const EMPTY_ENDING_TAG_REGEX = '/<\\?php$/';
+
     /**
      * @var string
      * @see https://regex101.com/r/jUFizd/1
@@ -76,6 +91,8 @@ final class BetterStandardPrinter extends Standard
     public function __construct(
         private IndentCharacterDetector $indentCharacterDetector,
         private DocBlockUpdater $docBlockUpdater,
+        private CurrentFileProvider $currentFileProvider,
+        private SmartFileSystem $smartFileSystem,
         array $options = []
     ) {
         parent::__construct($options);
@@ -102,6 +119,20 @@ public function printFormatPreserving(array $stmts, array $origStmts, array $ori
 
         $content = parent::printFormatPreserving($newStmts, $origStmts, $origTokens);
 
+        // strip empty starting/ending php tags
+        if (array_key_exists(0, $stmts) && $stmts[0] instanceof FileWithoutNamespace) {
+            $originalContent = $content;
+
+            $newContent = Strings::replace($content, self::EMPTY_STARTING_TAG_REGEX, '');
+            $newContent = Strings::replace(\rtrim($newContent), self::EMPTY_ENDING_TAG_REGEX, '',) . "\n";
+
+            if ($originalContent !== $newContent) {
+                /** @var File $file */
+                $file = $this->currentFileProvider->getFile();
+                return $this->smartFileSystem->readFile($file->getFilePath());
+            }
+        }
+
         // add new line in case of added stmts
         if (count($stmts) !== count($origStmts) && ! StringUtils::isMatch($content, self::NEWLINE_END_REGEX)) {
             $content .= $this->nl;

src/ValueObjectFactory/ProcessResultFactory.php

@@ -7,6 +7,7 @@
 use Rector\Core\Application\FileSystem\RemovedAndAddedFilesCollector;
 use Rector\Core\ValueObject\Application\File;
 use Rector\Core\ValueObject\ProcessResult;
+use Rector\Core\ValueObject\Reporting\FileDiff;
 use Rector\PostRector\Collector\NodesToRemoveCollector;
 
 final class ProcessResultFactory
@@ -28,11 +29,16 @@ public function create(array $files): ProcessResult
         foreach ($files as $file) {
             $errors = array_merge($errors, $file->getErrors());
 
-            if ($file->getFileDiff() === null) {
+            $fileDiff = $file->getFileDiff();
+            if (! $fileDiff instanceof FileDiff) {
                 continue;
             }
 
-            $fileDiffs[] = $file->getFileDiff();
+            if ($fileDiff->getDiff() === '') {
+                continue;
+            }
+
+            $fileDiffs[] = $fileDiff;
         }
 
         return new ProcessResult(