Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Remove RemoveAssignOfVoidReturnFunctionRector as unreliable, let PHPStan report and use handle various cases #1313

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Nov 25, 2021

This rule can be in some cases intentional, in some cases dangerous.
It will be better to report the case and let user decide, what to do about it.

…e, let PHPStan report and use handle various cases
@TomasVotruba TomasVotruba enabled auto-merge (squash) November 25, 2021 18:59
@TomasVotruba TomasVotruba merged commit aa72166 into main Nov 25, 2021
@TomasVotruba TomasVotruba deleted the tv-yield-warning branch November 25, 2021 19:03
@TomasVotruba
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant