[DX] Add configure() method to service configuration to make configuration easy again #1276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using Symfony PHP fluent configuration to add autocomplete and ECS, PHPStan and Rector luxury to configs.
Yet it comes for a price, of complex configuration, mainly in case of value objects. Symfony container cannot work with value objects natively, so extra inlining complexity has to be added:
Also it's prone to errors:
🔴
🔴
This bothers the user with boring knowledge. 👎
New
->configure(...)
method 🎉Instead, this PR gets the simplicity back. Rector DI itself handles the value object wrapping by adding special
->configure()
method.Before 🤧
Now 👍
With
array
parameter type hint useful for PHPStorm and PHPStan as a bonus ✔️