[CodeQuality] Skip increment variable on else on TernaryFalseExpressi…

…onToIfRector (#5867)

* [CodeQuality] Skip increment variable on if and else on TernaryFalseExpressionToIfRector

* [CodeQuality] Skip increment variable on else on TernaryFalseExpressionToIfRector

* fix

rules-tests/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector/Fixture/include_no_side_effect_expr.php.inc

@@ -8,6 +8,11 @@ final class IncludeNoSideEffectExpr
     {
         $value ? $someMethod->call($value) : true;
     }
+
+    public function run2($value, $someMethod, $variable)
+    {
+        $value ? $someMethod->call($value) : $variable;
+    }
 }
 
 ?>
@@ -24,6 +29,13 @@ final class IncludeNoSideEffectExpr
             $someMethod->call($value);
         }
     }
+
+    public function run2($value, $someMethod, $variable)
+    {
+        if ($value) {
+            $someMethod->call($value);
+        }
+    }
 }
 
 ?>

rules-tests/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector/Fixture/skip_increment_variable_on_else.php.inc

@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Expression\TernaryFalseExpressionToIfRector\Fixture;
+
+final class SkipIncrementVariableOnElse
+{
+    public function run($id)
+    {
+        $success = $failed = 0;
+        $id ? ++$success : ++$failed;
+
+        if ($success > $failed) {
+            return $success;
+        }
+
+        return $failed;
+    }
+
+    public function run2($id)
+    {
+        $success = $failed = 0;
+        ! $id ? ++$failed : ++$success;
+
+        if ($success > $failed) {
+            return $success;
+        }
+
+        return $failed;
+    }
+}

rules/CodeQuality/Rector/Expression/TernaryFalseExpressionToIfRector.php

@@ -7,10 +7,11 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Ternary;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\If_;
 use PHPStan\Analyser\Scope;
-use Rector\DeadCode\SideEffect\SideEffectNodeDetector;
+use Rector\NodeAnalyzer\ExprAnalyzer;
 use Rector\Rector\AbstractScopeAwareRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -21,7 +22,7 @@
 final class TernaryFalseExpressionToIfRector extends AbstractScopeAwareRector
 {
     public function __construct(
-        private readonly SideEffectNodeDetector $sideEffectNodeDetector
+        private readonly ExprAnalyzer $exprAnalyzer
     ) {
     }
 
@@ -77,10 +78,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
             return null;
         }
 
-        if ($this->sideEffectNodeDetector->detect(
-            $ternary->else,
-            $scope
-        ) || $this->sideEffectNodeDetector->detectCallExpr($ternary->else, $scope)) {
+        if (! $ternary->else instanceof Variable && $this->exprAnalyzer->isDynamicExpr($ternary->else)) {
             return null;
         }