[Reflection] Clean up unnecessary loop parents on ReflectionResolver (…

…#6146) * [Reflection] Clean up unnecessary loop on ReflectionResolver * more clean up
rectorphp · Jul 14, 2024 · a9ddf8f · a9ddf8f
1 parent 4dd889a
commit a9ddf8f
Showing 1 changed file with 4 additions and 37 deletions.
diff --git a/src/Reflection/ReflectionResolver.php b/src/Reflection/ReflectionResolver.php
@@ -106,25 +106,8 @@ public function resolveClassReflectionSourceObject(
                 return $classReflection;
             }
 
-            $nativeReflection = $classReflection->getNativeReflection();
-            $properties = $nativeReflection->getProperties();
-            // no need to lookup properties on interfaces
-            $ancestors = $classReflection->getParents();
-
-            foreach ($properties as $property) {
-                if ($property->getName() !== $propertyName) {
-                    continue;
-                }
-
-                if ($property->getDeclaringClass()->getName() === $className) {
-                    return $classReflection;
-                }
-
-                foreach ($ancestors as $ancestor) {
-                    if ($ancestor->hasNativeProperty($propertyName)) {
-                        return $ancestor;
-                    }
-                }
+            if ($this->reflectionProvider->hasClass($property->getDeclaringClass()->getName())) {
+                return $this->reflectionProvider->getClass($property->getDeclaringClass()->getName());
             }
 
             return $classReflection;
@@ -140,24 +123,8 @@ public function resolveClassReflectionSourceObject(
             return $classReflection;
         }
 
-        $nativeReflection = $classReflection->getNativeReflection();
-        $methods = $nativeReflection->getMethods();
-        $ancestors = [...$classReflection->getParents(), ...$classReflection->getInterfaces()];
-
-        foreach ($methods as $method) {
-            if ($method->getName() !== $methodName) {
-                continue;
-            }
-
-            if ($method->getDeclaringClass()->getName() === $className) {
-                return $classReflection;
-            }
-
-            foreach ($ancestors as $ancestor) {
-                if ($ancestor->hasNativeMethod($methodName)) {
-                    return $ancestor;
-                }
-            }
+        if ($this->reflectionProvider->hasClass($extendedMethodReflection->getDeclaringClass()->getName())) {
+            return $this->reflectionProvider->getClass($extendedMethodReflection->getDeclaringClass()->getName());
         }
 
         return $classReflection;