Add known type casting to AnnotationToAttributeRector

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Symfony/validation_string_parameter.php.inc

@@ -29,7 +29,7 @@ use Symfony\Component\Validator\Constraints as Assert;
 
 final class ValidationIntegerParameter
 {
-    #[Assert\Length(min: '100', max: '255', maxMessage: 'some Message', allowed: 'true')]
+    #[Assert\Length(min: 100, max: 255, maxMessage: 'some Message', allowed: 'true')]
     public function action()
     {
     }

src/PhpAttribute/Enum/AnnotationClassName.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PhpAttribute\Enum;
+
+final class AnnotationClassName
+{
+    /**
+     * @var string
+     */
+    public const LENGTH = 'Symfony\Component\Validator\Constraints\Length';
+}

src/PhpAttribute/NodeFactory/AnnotationToAttributeKeyTypeCaster.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PhpAttribute\NodeFactory;
+
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\ArrayItem;
+use PhpParser\Node\Scalar\LNumber;
+use PhpParser\Node\Scalar\String_;
+use Rector\Php80\ValueObject\AnnotationToAttribute;
+use Rector\PhpAttribute\Enum\AnnotationClassName;
+
+final class AnnotationToAttributeKeyTypeCaster
+{
+    /**
+     * @var array<string, string[]>
+     */
+    private const INTEGER_KEYS_BY_CLASS = [
+        AnnotationClassName::LENGTH => ['min', 'max'],
+    ];
+
+    /**
+     * @param Arg[] $args
+     */
+    public function castAttributeTypes(AnnotationToAttribute $annotationToAttribute, array $args): void
+    {
+        // known type casting
+        foreach (self::INTEGER_KEYS_BY_CLASS as $annotationClass => $integerKeys) {
+            if ($annotationToAttribute->getAttributeClass() !== $annotationClass) {
+                continue;
+            }
+
+            foreach ($integerKeys as $integerKey) {
+                foreach ($args as $arg) {
+                    if (! $arg->value instanceof ArrayItem) {
+                        continue;
+                    }
+
+                    $arrayItem = $arg->value;
+                    if (! $arrayItem->key instanceof String_) {
+                        continue;
+                    }
+
+                    if ($arrayItem->key->value !== $integerKey) {
+                        continue;
+                    }
+
+                    // ensure type is casted to integer
+                    if ($arrayItem->value instanceof String_) {
+                        $arrayItem->value = new LNumber((int) $arrayItem->value->value);
+                    }
+                }
+            }
+        }
+    }
+
+}

src/PhpAttribute/NodeFactory/PhpAttributeGroupFactory.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\ArrayItem;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Scalar\LNumber;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Use_;
 use Rector\BetterPhpDocParser\PhpDoc\ArrayItemNode;
@@ -21,6 +22,7 @@
 use Rector\Php81\Enum\AttributeName;
 use Rector\PhpAttribute\AnnotationToAttributeMapper;
 use Rector\PhpAttribute\AttributeArrayNameInliner;
+use Rector\PhpAttribute\Enum\AnnotationClassName;
 
 /**
  * @see \Rector\Tests\PhpAttribute\Printer\PhpAttributeGroupFactoryTest
@@ -31,7 +33,8 @@ public function __construct(
         private AnnotationToAttributeMapper $annotationToAttributeMapper,
         private AttributeNameFactory $attributeNameFactory,
         private NamedArgsFactory $namedArgsFactory,
-        private AttributeArrayNameInliner $attributeArrayNameInliner
+        private AttributeArrayNameInliner $attributeArrayNameInliner,
+        private \Rector\PhpAttribute\NodeFactory\AnnotationToAttributeKeyTypeCaster $annotationToAttributeKeyTypeCaster,
     ) {
     }
 
@@ -79,6 +82,8 @@ public function create(
             $annotationToAttribute->getClassReferenceFields()
         );
 
+        $this->annotationToAttributeKeyTypeCaster->castAttributeTypes($annotationToAttribute, $args);
+
         $args = $this->attributeArrayNameInliner->inlineArrayToArgs($args);
 
         $attributeName = $this->attributeNameFactory->create(

stubs/Symfony/Component/Validator/Constraints/Length.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\Validator\Constraints;
+
+if (class_exists('Symfony\Component\Validator\Constraints\Length')) {
+    return;
+}
+
+class Length
+{
+}