fix:Fix text color reverting to default after changing tintColor #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsantos91
approved these changes
Oct 11, 2023
|
Can we get a go on this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I noticed a bug where the text color of the component would revert back to its default value after changing the tintColor. This behavior is not ideal as it disrupts the user experience and makes the component less flexible for dynamic UI changes. My motivation for making this change is to fix this issue and improve the component's reliability.
related with #641
Test Plan
Manually tested the component on multiple devices running iOS 13 and above.
Changed the tintColor dynamically after the component had rendered to verify that the text color does not revert to its default value.
Checked other properties to ensure they are not affected by this change.