-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example react native test app #594
Example react native test app #594
Conversation
…ct-native-test-app
…janaRao/segmented-control into example-react-native-test-app
Awesome! Will review soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YajanaRao
Thanks for the changes! CI seems to be failing, so could you make the following changes?
- run
yarn lint --fix
to apply fix for lint error - in
ci.yml
file, underandroid:
, add a step to install and build packages in the example directory after yarn install
it should look like this:
- name: Install Dependencies
run: yarn
- name: Install Example Dependencies
run: cd example && yarn
- name: Build android
run: cd example && yarn build:android
- name: Build Android Example App and Library
run: cd example/android && ./gradlew clean assembleDebug
- also in
ci.yml
file, underios:
, add a step to install and build packages in the example directory after yarn install
- name: Install Dependencies
run: yarn
- name: Install Example
run: cd example && yarn
- name: Build ios
run: cd example && yarn build:ios
- name: Pod install
run: cd example && pod install --project-directory=ios
- name: Run ios app
run: cd example && yarn ios
@Naturalclar I have done the changes you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YajanaRao thanks for the changes!
sorry, there was one more fix that needed to be done.
the default java version in ci is 8, but current android build required java 11, so android job needs to be set up to use java 11.
Could you add actions/setup-java
in the ci and make it use java 11?
setup should look something like this:
android:
runs-on: ubuntu-18.04
strategy:
matrix:
node-version: [16]
java-version: [11]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ matrix.java-version }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YajanaRao awesome! thanks again for the fixes. merging this PR
Overview
Fixes #583
Updated example project with react native test app. Re used App.js code. 1.4.6 was the version for react native 0.63.
Link to discussion: microsoft/react-native-test-app#1155
Test Plan