Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ColorValue for color props #53

Merged
merged 1 commit into from
Mar 12, 2020
Merged

use ColorValue for color props #53

merged 1 commit into from
Mar 12, 2020

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Mar 11, 2020

Overview

motivation: ColorValue is the intended flow type for color props

Test Plan

I didn't actually test this, but the definition of ColorValue is type ColorValue = null | string; so I don't see why it would break anything

Naturalclar
Naturalclar approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Naturalclar Naturalclar merged commit 1ff3fb3 into master Mar 12, 2020
@Naturalclar Naturalclar deleted the use-ColorValue branch March 12, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonovak @Naturalclar