Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added accesibility for selected tab #219

Merged
merged 2 commits into from
Mar 20, 2021
Merged

feat: added accesibility for selected tab #219

merged 2 commits into from
Mar 20, 2021

Conversation

AaronITP
Copy link
Contributor

@AaronITP AaronITP commented Mar 8, 2021

Overview

A small change, accessibilityState added so that the selected tab is specified out loud for TalkBack on android.

Naturalclar
Naturalclar approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronITP awesome, thanks so much!

@Naturalclar Naturalclar changed the title feat added accesibility for selected tab feat: added accesibility for selected tab Mar 20, 2021
@Naturalclar Naturalclar merged commit bfb27d6 into react-native-segmented-control:master Mar 20, 2021
@thibmaek thibmaek mentioned this pull request Apr 21, 2021
Open
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
@semantic-release-bot
chore(release): 2.4.0 [skip ci]
671700c 
# [2.4.0](v2.3.0...v2.4.0) (2021-06-30)

### Features

* added accesibility for selected tab ([#219](#219)) ([bfb27d6](bfb27d6))
* setup auto deploy ([#227](#227)) ([4ee3a07](4ee3a07))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronITP @Naturalclar