Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py_minor_version check in setup.py #241

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

calebsyring
Copy link
Contributor

Fix for bug introduced in #240

The in operator preceded the walrus operator resulting in the comparison being True >= 10 and still pinning the Django version to <5 regardless of python version. The parentheses added fix this problem, and I used the minor attribute instead of index for readability.

The build didn't catch this because the installation of django-twilio came after the installation of django at the specified version, which was uninstalling django and reinstalling a compatible version. I rearranged the build so that this problem is demonstrated when it occurs.

@calebsyring
Copy link
Contributor Author

calebsyring commented Mar 27, 2024

@jheld the build will now show the dependency conflict in the logs and make sure that the django version specified by the matrix overrides the one in setup.py. It won't actually fail the build in the case of a conflict, though (see below). I think something like a bash script checking the output of pip check might be necessary for that (which seems overkill to me). Let me know if you think that's essential.

image

@jheld jheld merged commit 0823f5b into rdegges:develop Mar 27, 2024
29 checks passed
@jheld
Copy link
Collaborator

jheld commented Mar 27, 2024

released a1 to PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants