Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structopt instead of docopt #737

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lu-zero
Copy link

@lu-zero lu-zero commented Mar 16, 2020

It might or might not be nicer to use. (this got prompt by docopt somehow crashing rustc nightly on power9)

@cuviper
Copy link
Member

cuviper commented Mar 17, 2020

I think if we change this, it should be done for rayon-demo too for consistency. Direct clap is another option, since structopt is just a fancy wrapper on that.

Or since this is just a tiny example program, I think it would be fine with manual arg parsing, and get rid of the dev-dependency in rayon altogether.

(this got prompt by docopt somehow crashing rustc nightly on power9)

ref: rust-lang/rust#70041

@lu-zero
Copy link
Author

lu-zero commented Mar 18, 2020

I prefer using structopt (or gumdrop if we want to keep the build times smaller) since it makes the code more compact, not distracting from the important parts and produces informative --help that do not go out of sync easily.

I can convert rayon demo today if there is consensus for it.

@cuviper
Copy link
Member

cuviper commented Mar 18, 2020

I can convert rayon demo today if there is consensus for it.

I don't have a strong opinion on what we use, especially since this is only for examples and demos. The fact that docopt declares itself unmaintained is reason enough to find something else. If you're willing to do the rest of the conversion, structopt should be fine.

@nikomatsakis
Copy link
Member

For the record I'm fine with structopt :)

@palango palango mentioned this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants