Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Heroku #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hunterloftis
Copy link

We get several tickets from users who have trouble deploying these socket.io demos because of small pieces (no npm start, hardcoded port, etc). This makes it easier to get up and running:

  • made npm start work
  • using port 3000 as default if no PORT var is specified
  • added app.json file for deploy button
  • added deploy button to bottom of readme

port env var

added app.json

formatting

free dyno
@@ -1,7 +1,11 @@
# chat-example

This is the source code for a very simple chat example used for
the [Getting Started](http://socket.io/get-started/chat/) guide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

TheSachinSBhat added a commit to TheSachinSBhat/chat-example-1 that referenced this pull request Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants