SDK & API issues: sell order creation via node script after lazy mint

[Theo6890]

Hi all,

Everything is in the title and there are 2 differents errors that prevents me to programmatically create sell order with both API & SDK.

Here - Rinkeby Rarible is the token from the 0x2f1d12e8f51238ae54b33dd8a2832776d20dcf5a collection (created via ERC721 factory) I'm trying to sell (there is an issue with pictures as the id doesnt start at 1 but generated using the API/SDK 🤔)

1. SDK issue

@rarible\ethereum-api-client: FormatData is not defined

Configure the SDK

const configureSDK = async () => {
  const hdwProvider = new HDWalletProvider({
    mnemonic: {
      phrase: process.env.SEED,
    },
    providerOrUrl: "https://rinkeby.infura.io/v3/" + process.env.INFURA_KEY,
  });
  // const addresses = hdwProvider.getAddresses();

  const web3 = new Web3(hdwProvider);
  web3.setProvider(hdwProvider);

  const web3Eth = new Web3Ethereum({ web3 });
  const sdk = new createRaribleSdk(web3Eth, "rinkeby", {
    fetchApi: await fetch("https://ethereum-api-staging.rarible.org/"),
  }
  );

  return sdk;
};

Use the SDK to create a sell order

  const sdk = await configureSDK();

  // Sell request example:
  //   const contractErc20Address = "0x0"; // your ERC20 contract address
  const sellerAddress = "0x0c61B1d5C23b5B8DAB2CC31a147f91Dd44ef1e17"; // Owner of ERC721 token
  const nftAmount = 1; // For ERC721 always be 1
  const sellPrice = 0.01; // price per unit of ERC721 or ERC721 token(s)
  const request = {
    makeAssetType: {
      assetClass: "ERC721",
      contract: erc721Address,
      tokenId: tokenId,
    },
    maker: sellerAddress,
    amount: nftAmount,
    originFees: [],
    payouts: [],
    price: sellPrice,
    takeAssetType: { assetClass: "ETH" },
  };

  const order = await sdk.order.sell(request).then((a) => a.runAll());

  return order;

Call sell order function

async function main() {
  await sellCollection(
    5600365720309724869877271420695346487553468277285076864772940804007099629681
  );
}

Though the call fails because FormData is not defined in @rarible\ethereum-api-client\build\runtime.js:178:45: whole error message. This is the issue encountered on the SDK side.

2. API issue

Using deprecated v0.1/order/encoder/order

When I try to encode the order I get a 400: BAD_REQUEST answer with:

Cannot deserialize instance of `java.math.BigInteger` out of VALUE_NUMBER_FLOAT token at [Source: (io.netty.buffer.ByteBufInputStream); line: 1, column: 184] 

(through reference chain: com.rarible.protocol.dto.RaribleV2OrderFormDto["make"]->com.rarible.protocol.dto.OrderFormAssetDto["assetType"]->com.rarible.protocol.dto.Erc721AssetTypeDto["tokenId"])

Here is how I make the call to ``v0.1/order/encoder/order`:

console.log("start encding order...");
    const raribleEncodeOrderUrl = `${baseUrl}/v0.1/order/encoder/order`;
    const res = await axios.post(raribleEncodeOrderUrl, JSON.stringify(form), {
      headers: { "Content-Type": "application/json" },
    });
    console.log("signMessage: %s\n\n", res.data.signMessage);

As you can see here, only start encding order... is printed (and the form before that). There is not any issues with form as you can see.

[evgenynacu]

@Theo6890 if you want to use SDK in node.js you should do something like this (from our tests):
https://github.com/rarible/sdk/blob/d6952fe42a3c6e287df8ca5b91f2a2994c8d6347/packages/sdk/jest.setup.js

global.FormData = require("form-data")

Regarding 2nd issue:

1. What json are you trying to post? Let me know
2. This endpoint is deprecated thus will be removed in the future. It's better to use SDK for this

[Theo6890]

Indeed you use a pretty similar provider I'll try another way and see how it goes

[Theo6890]

Nothing works even ethers 🤷‍♂️

EDIT: it does using ethers this way

const { EthersEthereum } = require("@rarible/ethers-ethereum");
const fetch = (...args) =>
  import("node-fetch").then(({ default: fetch }) => fetch(...args));

global.FormData = require("form-data");
global.window = {
  fetch: fetch,
  dispatchEvent: () => {},
};

const { createRaribleSdk } = require("@rarible/protocol-ethereum-sdk");

const configureSDK = async () => {
  const [owner] = await ethers.getSigners();

  const sdk = new createRaribleSdk(new EthersEthereum(owner), "rinkeby", {
    fetch: fetch, // refers to the object above
  });

  return sdk;
};

Though to after that same error than using the API to create sell order: tokenId is too big to be a number (I've generated it using the API 🤔 5600365720309724869877271420695346487553468277285076864772940804007099629681)

[evgenynacu]

You can send it as a string, API should accept both: strings and numbers

[Theo6890]

yep it I've figured it all out (forgot to update this but share in the Discord). https://gist.github.com/Theo6890/e70b686b03944585ef8d55061419cae4

There is just an issue wit Rarible frontend no display content but that's another issue

[shashank42]

For typescript in nodejs try this snippet to initialize the sdk

import fetchIso from 'isomorphic-fetch'; // node-fetch gives some ts errors
const { EthersEthereum } = require("@rarible/ethers-ethereum");
import { createRaribleSdk } from "@rarible/protocol-ethereum-sdk";
import signer from "../nftWeb3/signers"; // Get your ethersjs signer

global.FormData = require("form-data");
global.window = {
	fetch: fetchIso,
    // @ts-ignore
	dispatchEvent: () => {
	},
};
// @ts-ignore
global.CustomEvent = function CustomEvent() {
	return
};

const sdk = createRaribleSdk(new EthersEthereum(signer), "ropsten", {
    fetchApi: fetchIso,
  });

[sirgawain0x]

#198 (reply in thread)