Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-merge branch-24.10 into branch-24.12 #6077

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Forward-merge branch-24.10 into branch-24.12 #6077

merged 1 commit into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. Stop shadowing free function (#6076) 

    I think this is currently working because [the function defined in fil.h is templated](https://github.com/rapidsai/cuml/blob/branch-24.10/python/cuml/cuml/fil/fil.pyx#L324), whereas the base C free function is not, and so Cython is parsing this correctly. However, not all versions of Cython can parse this correctly, and cuml currently fails to build on the trunk of Cython repository as a result.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Bradley Dice (https://github.com/bdice)

URL: #6076
    @vyasr
    vyasr committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0400d7a View commit details
    Browse the repository at this point in the history