Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MSRV down to 1.56 #71

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Drop MSRV down to 1.56 #71

merged 1 commit into from
Apr 1, 2024

Conversation

GnomedDev
Copy link
Contributor

Currently, my project is pulling in a duplicate version of this library as darling is pulling 0.10, my attempt to fix this was stopped by the MSRV of 0.11 being raised higher than darling, and since this is a literal one line fix (+ CI) I would love if this got pulled in.

@maxbachmann maxbachmann merged commit d84fd91 into rapidfuzz:main Apr 1, 2024
10 checks passed
@maxbachmann
Copy link
Member

Thanks for the contribution. I think I only changed this at some point since clippy recommended it to me and I didn't know enough about rust to understand the implications. I will make a quick 11.1 with the change tomorrow.

@GnomedDev
Copy link
Contributor Author

Actually, I can fix that. I'll make a followup to set the rust-version field of Cargo.toml which clippy should respect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants