Excluding test folders from snyk scan (test data) #19483
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash snyk code test pre: 469 Code issues found 35 [High] 298 [Medium] 136 [Low] post: 160 Code issues found 28 [High] 71 [Medium] 61 [Low] ```
jvoisin
reviewed
Sep 20, 2024
.snyk
Outdated
Comment on lines
6
to
9
| # includes our unit tests which include hard coded passwords and encrypting keys for testing purposes. | ||
| - spec/ | ||
| # includes the source code to local exploits and utilities which have to be written in a particular way to exploit the vulnerabilities that we're targeting. | ||
| - external/source/ |
There was a problem hiding this comment.
Suggested change
| # includes our unit tests which include hard coded passwords and encrypting keys for testing purposes. | |
| - spec/ | |
| # includes the source code to local exploits and utilities which have to be written in a particular way to exploit the vulnerabilities that we're targeting. | |
| - external/source/ | |
| # exclude our unit tests which contain hard coded passwords and encrypting keys for testing purposes. | |
| - spec/ | |
| # exclude the source code to local exploits and utilities which have to be written in a particular way to exploit the vulnerabilities that we're targeting. | |
| - external/source/ |
Otherwise, it's a tad confusing :D
There was a problem hiding this comment.
Otherwise, it's a tad confusing :D
Sorry, was copying quotes from ticket, where it made sense in context of exception.
Here is opposite, correct.
jvoisin
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding test folders for Snyk scans.
Makes zero changes to actual application.
Verification
List the steps needed to make sure this thing works
msfconsoleuse exploit/windows/smb/ms08_067_netapi.Testing:
snyk code test pre: 469 Code issues found 35 [High] 298 [Medium] 136 [Low] post: 160 Code issues found 28 [High] 71 [Medium] 61 [Low]