Follow-up: Fix parsing empty responses #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2021 19:55
When a Content-Type header is given when there is actually no content, rapidoc should handle that
If there is no statusText => don't prepend status with ':'
|
I noticed I was just 5 minutes too late 😅 |
|
thanks for taking care of it ...!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the fix in PR #434 wasn't correct (the wrong variable was set to empty, so the response box wasn't getting cleared, in case you already had a response from a previous request), and I already pushed extra commits to my branch, but didn't notice you already merged the other PR.
So this is a rebase of my branch.