Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response-area-height doesn't appear to have any effect #768

Closed
colvinco opened this issue Jun 9, 2022 · 0 comments
Closed

response-area-height doesn't appear to have any effect #768

colvinco opened this issue Jun 9, 2022 · 0 comments

Comments

@colvinco
Copy link

colvinco commented Jun 9, 2022

Hello,

https://rapidocweb.com/api.html#att-layout describes response-area-height as follows:

response-area-height Allowed: valid css height value such as 400px, 50%, 60vh etc - Use this value to control the height of response textarea 300px

It was added for #110 , but it doesn't appear to do anything

Looking through the source, it is picked up:

  1. responseAreaHeight: { type: String, attribute: 'response-area-height' } - https://github.com/rapi-doc/RapiDoc/blob/master/src/rapidoc.js#L64
  2. --resp-area-height: ${this.responseAreaHeight}; - https://github.com/rapi-doc/RapiDoc/blob/master/src/utils/theme.js#L208
.multiline {
    overflow: scroll;
    max-height: var(--resp-area-height, 300px);
    color: var(--fg3);
}

https://github.com/rapi-doc/RapiDoc/blob/master/src/styles/font-styles.js#L43

However multiline doesn't appear to be used as a class on the response areas (or anywhere else?). If I apply the multiline class to a response area then the setting does limit the height as expected.

Am I missing something or is this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant