Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes and additional QC #194

Merged
merged 9 commits into from
Aug 30, 2023
Merged

bug fixes and additional QC #194

merged 9 commits into from
Aug 30, 2023

Conversation

balabanmetin
Copy link
Member

@balabanmetin balabanmetin commented Aug 28, 2023

  • When phasing SNPs, shapeit -check does not create the {chromosome}_alignments.snp.strand.exclude if there is no SNPs to be excluded. Inputting shapeit a non-existent file raises an error. We now create an empty file instead when the exclude file is not created.
  • Genotype SNPs now uses minimum coverage parameter self.mincov. Previously it has never been used.
  • When input BAM and VCF files misses .bai and.tbi indices respectively, we detect and raise an exception. Otherwise the workflow crashes later and it is very difficult to find the reason why it happened.
  • pandas depreciated feature is no longer used in cluster_bins

@codecov-commenter
Copy link

Codecov Report

Merging #194 (b2b1a49) into master (d3b38e4) will decrease coverage by 0.08%.
The diff coverage is 23.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   51.32%   51.25%   -0.08%     
==========================================
  Files          34       34              
  Lines        6963     6967       +4     
==========================================
- Hits         3574     3571       -3     
- Misses       3389     3396       +7     
Files Changed Coverage Δ
src/hatchet/utils/genotype_snps.py 58.33% <0.00%> (-3.08%) ⬇️
src/hatchet/utils/phase_snps.py 56.55% <0.00%> (-0.40%) ⬇️
src/hatchet/utils/ArgParsing.py 70.29% <75.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@mmyers1 mmyers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@balabanmetin balabanmetin merged commit 9226e44 into master Aug 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants