ADR: Clusterctl Config resoruce #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
adr-clusterctl-provider
branch
2 times, most recently
from
98347fa
to
c12abc6
Compare
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
adr-clusterctl-provider
branch
from
c12abc6
to
5e39433
Compare
furkatgofurov7
previously approved these changes
Sep 4, 2024
Danil-Grigorev
force-pushed
the
adr-clusterctl-provider
branch
from
5e39433
to
e93c079
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
adr-clusterctl-provider
branch
from
e93c079
to
ad90ff1
Compare
alexander-demicev
approved these changes
Sep 4, 2024
furkatgofurov7
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change will add a configurability layer on top of the default state of the
clusterctl.yamlConfigMap, exposed to users as a public API.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: