Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.27] Shell completion and etcd connection fix #6615

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Aug 21, 2024

Proposed Changes

Types of Changes

  • backports

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner August 21, 2024 16:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 6.18557% with 91 lines in your changes missing coverage. Please review.

Project coverage is 25.20%. Comparing base (9e51142) to head (4ad8b9d).
Report is 1 commits behind head on release-1.27.

Files Patch % Lines
pkg/cli/cmds/completion.go 4.39% 87 Missing ⚠️
pkg/rke2/rke2_linux.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #6615      +/-   ##
================================================
- Coverage         25.82%   25.20%   -0.63%     
================================================
  Files                32       33       +1     
  Lines              2722     2817      +95     
================================================
+ Hits                703      710       +7     
- Misses             1974     2063      +89     
+ Partials             45       44       -1     
Flag Coverage Δ
inttests 9.51% <6.18%> (-0.12%) ⬇️
unittests 17.82% <0.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 5c07ccd into rancher:release-1.27 Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants