Add updatecli configuration to update vsphere cpi and csi charts #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results from dry-run: vsphere-csivsphere-cpi |
matttrach
requested changes
Jan 31, 2024
brandond
approved these changes
Jan 31, 2024
manuelbuil
reviewed
Feb 1, 2024
| user: "{{ .github.user }}" | ||
| email: "{{ .github.email }}" | ||
| username: "{{ requiredEnv .github.username }}" | ||
| token: '{{ requiredEnv .github.token }}' |
There was a problem hiding this comment.
Does this work for you? I had problems when using the token from values.yaml
There was a problem hiding this comment.
it works locally with updatecli and I used act as well to test the workflow, it seems to be working fine
cwayne18
approved these changes
Apr 16, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
force-pushed
the
automatic_update_for_vsphere_charts
branch
from
b399130
to
efc488a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5326 +/- ##
=======================================
Coverage 25.23% 25.23%
=======================================
Files 33 33
Lines 2829 2829
=======================================
Hits 714 714
Misses 2068 2068
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Jul 15, 2024
iamsarthakk
pushed a commit
to iamsarthakk/rke2
that referenced
this pull request
Aug 19, 2024
…cher#5326) * Add updatecli configuration to update vsphere cpi and csi charts Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * use updatecli version v0.72.0 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * remove updatecli default steps and add vsphere charts Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> --------- Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add updatecli steps to update vsphere-csi/vsphere-cpi charts and images
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments