Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multus v4.1.0 #511

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Sep 2, 2024

Signed-off-by: Michael Fritch <mfritch@suse.com>
- strip `v` prefix from the generated semver
- apply the `appVersion` after the multus image version

See also: rancher#509
Signed-off-by: Michael Fritch <mfritch@suse.com>
Generated via manual run:
```
$ MULTUS_VERSION="v4.1.0-build20240830" ./updatecli/scripts/update-multus.sh
```

Signed-off-by: Michael Fritch <mfritch@suse.com>
@brandond
Copy link
Member

brandond commented Sep 3, 2024

LGTM once conflict is resolved

@thomasferrandiz
Copy link
Contributor

@mgfritch it looks like you updated cilium instead of multus in this PR.
I guess that's why you had an issue when testing multus + whereabouts.

@mgfritch
Copy link
Contributor Author

mgfritch commented Sep 4, 2024

I actually encountered a known issue upgrading the CRDs in the whereabouts subchart.
The force push was simply a rebase against main-source but shouldn't affect this PR

@mgfritch mgfritch merged commit 5203bb8 into rancher:main-source Sep 4, 2024
1 check passed
@mgfritch mgfritch deleted the update-multus-v4.1.0 branch September 4, 2024 15:16
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants