Add cni path config in whereabouts to make it work in k3s #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Mar 22, 2024
| @@ -46,5 +46,9 @@ tolerations: | |||
|
|
|||
| affinity: {} | |||
|
|
|||
| cni_conf: | |||
There was a problem hiding this comment.
does it have to be cni_conf? The convention is to use camelCase in yaml, not underscores. Maybe just cni or cniConf?
Suggested change
| cni_conf: | |
| cni: |
There was a problem hiding this comment.
good point! I just copied what Multus is using
manuelbuil
force-pushed
the
whereAboutsCNIPaths
branch
2 times, most recently
from
2066f2f
to
a91a23a
Compare
manuelbuil
requested review from
brandond,
mgfritch,
rbrtbnfgl and
thomasferrandiz
brandond
approved these changes
Mar 25, 2024
mgfritch
approved these changes
Mar 25, 2024
|
yeah, I think we should bump both the chart, and the subchart? |
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
whereAboutsCNIPaths
branch
from
a91a23a
to
4b879a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNI binaries and CNI config files do not use the default paths in k3s, therefore, we need a way to configure those parameters if we want to use whereabouts
Multus version must be incremented because it embeds whereabouts